Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Test::Mojo::attr_* tests #1592

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Added Test::Mojo::attr_* tests #1592

merged 2 commits into from
Nov 2, 2020
+25 −0

Conversation

rage311
Copy link
Contributor

@rage311 rage311 commented Oct 30, 2020

Summary

Added Test::Mojo::attr_* tests

Motivation

Requested changes in #1488

References

#1488

@kraih kraih requested a review from a team October 30, 2020 10:23
kraih
kraih previously requested changes Oct 30, 2020
View reviewed changes
Copy link
Member

@kraih kraih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits.

@mergify mergify bot dismissed kraih’s stale review October 30, 2020 18:37

Pull request has been modified.

jhthorsen
jhthorsen previously approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2020

This pull request is now in conflicts. Could you fix it @rage311? 🙏

kraih
kraih previously approved these changes Nov 1, 2020
View reviewed changes
@kraih kraih dismissed stale reviews from jhthorsen and themself via 65e0d3d November 2, 2020 10:36
@kraih kraih requested a review from a team November 2, 2020 10:37
jhthorsen
jhthorsen approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still okidoki 👍

@mergify mergify bot merged commit 0ddf584 into mojolicious:master Nov 2, 2020
@rage311 rage311 mentioned this pull request Nov 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhthorsen jhthorsen jhthorsen approved these changes

@kraih kraih kraih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rage311 @kraih @jhthorsen